Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add ConfidenceValue #84

Merged
merged 18 commits into from
Apr 9, 2024
Merged

feat: Add ConfidenceValue #84

merged 18 commits into from
Apr 9, 2024

Conversation

fabriziodemaria
Copy link
Member

@fabriziodemaria fabriziodemaria commented Apr 2, 2024 •
edited
Loading

Following #83

Changelog:

  • Moves ConfidenceErrors to the Confidence lib
  • Adds ConfidenceValue for events' payload
  • Adds conversion utiles for ConfidenceValue<->OFValue
    • Heterogenous lists are defaulted to null values

Limitations:

  • Supports encoding to JSON, but not decoding from JSON

@fabriziodemaria fabriziodemaria changed the title Add ConfidenceValue feat: Add ConfidenceValue Apr 2, 2024
@fabriziodemaria fabriziodemaria force-pushed the confidence-value branch 3 times, most recently from 0986d99 to 0040092 Compare April 3, 2024 12:47
@fabriziodemaria fabriziodemaria marked this pull request as ready for review April 3, 2024 13:02
@fabriziodemaria fabriziodemaria mentioned this pull request Apr 4, 2024
Merged
nicklasl
nicklasl previously approved these changes Apr 5, 2024
View reviewed changes
@fabriziodemaria fabriziodemaria force-pushed the confidence-value branch 5 times, most recently from 8c84892 to 3b76ca1 Compare April 5, 2024 15:01
@fabriziodemaria fabriziodemaria merged commit 8de4b78 into main Apr 9, 2024
4 checks passed
@fabriziodemaria fabriziodemaria deleted the confidence-value branch April 9, 2024 08:37
@github-actions github-actions bot mentioned this pull request Apr 2, 2024
Merged
nickybondarenko pushed a commit that referenced this pull request Apr 10, 2024
@fabriziodemaria @nickybondarenko
feat: Add ConfidenceValue (#84)
4898acb 
* Add ConfidenceValue

* Add ConfidenceValueTests

* Remove DateComponents

* Simplify and finalize ConfidenceValue

* Test fix

* Update demo app

* Variable renaming

* ConfidenceValue is only Codable

* Add Confidence-OF converstions

* refactor: Restrict heterogeneous ConfidenceValue lists (#86)

* Change ConfidenceValue constructors for more control

* Setup for list restrictions

* Remove unused converters

* Change time-related arg labels

* Fix date format

* Explicit UTC settings and TZ tests

* Best effort convert OF lists

* Rename bool to boolean

* Rename TZ offset from timestamps

* Add swiftpm back
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreas-karlsson andreas-karlsson andreas-karlsson left review comments

@nicklasl nicklasl nicklasl approved these changes

@mfranberg mfranberg Awaiting requested review from mfranberg mfranberg is a code owner

@vahidlazio vahidlazio Awaiting requested review from vahidlazio vahidlazio is a code owner

@nickybondarenko nickybondarenko Awaiting requested review from nickybondarenko nickybondarenko is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fabriziodemaria @andreas-karlsson @nicklasl