Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Append EvalContext to Events #85

Merged
merged 2 commits into from
Apr 9, 2024
Merged

feat: Append EvalContext to Events #85

merged 2 commits into from
Apr 9, 2024

Conversation

fabriziodemaria
Copy link
Member

@fabriziodemaria fabriziodemaria commented Apr 4, 2024 •
edited
Loading

Print from Demo App:

Sending: "my_event".
Message: ["my_string_field": hello_from_world]
Context: ["open_feature": ["targeting_key": "4E577218-EA6B-4007-AD97-AA1DDA55D475", "country": "SE"]]

Related: #84

@fabriziodemaria fabriziodemaria changed the title [WIP] Append EvalContext to Events feat: [WIP] Append EvalContext to Events Apr 4, 2024
@fabriziodemaria fabriziodemaria force-pushed the confidence-value branch 5 times, most recently from 3b76ca1 to 3120a42 Compare April 5, 2024 15:02
Base automatically changed from confidence-value to main April 9, 2024 08:37
@fabriziodemaria fabriziodemaria changed the title feat: [WIP] Append EvalContext to Events feat: Append EvalContext to Events Apr 9, 2024
@fabriziodemaria fabriziodemaria marked this pull request as ready for review April 9, 2024 12:16
@fabriziodemaria fabriziodemaria merged commit 56f8130 into main Apr 9, 2024
4 checks passed
@fabriziodemaria fabriziodemaria deleted the ctx-in-events branch April 9, 2024 13:27
@github-actions github-actions bot mentioned this pull request Apr 9, 2024
Merged
nickybondarenko pushed a commit that referenced this pull request Apr 10, 2024
@fabriziodemaria @nickybondarenko
feat: Append EvalContext to Events (#85)
29ce489 
* Append EvalContext to Events

* Test context updates to Confidence
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vahidlazio vahidlazio vahidlazio approved these changes

@mfranberg mfranberg Awaiting requested review from mfranberg mfranberg is a code owner

@nicklasl nicklasl Awaiting requested review from nicklasl nicklasl is a code owner

@nickybondarenko nickybondarenko Awaiting requested review from nickybondarenko nickybondarenko is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fabriziodemaria @vahidlazio