refactor: Add Confidence Library scaffolding #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabriziodemaria
force-pushed
the
confidence-lib
branch
from
d2f805a to
c602699
Compare
fabriziodemaria
changed the title
fabriziodemaria
force-pushed
the
confidence-lib
branch
3 times, most recently
from
7a67af9 to
2f2abe1
Compare
fabriziodemaria
commented
Mar 28, 2024
fabriziodemaria
commented
Mar 28, 2024
fabriziodemaria
force-pushed
the
confidence-lib
branch
from
2f2abe1 to
839db71
Compare
fabriziodemaria
force-pushed
the
confidence-lib
branch
6 times, most recently
from
bef7f32 to
3f0eba0
Compare
fabriziodemaria
force-pushed
the
confidence-lib
branch
from
3f0eba0 to
e59b4cb
Compare
fabriziodemaria
changed the title
fabriziodemaria
requested review from
mfranberg,
vahidlazio,
nicklasl and
nickybondarenko
as code owners
fabriziodemaria
commented
Mar 28, 2024
fabriziodemaria
commented
Mar 28, 2024
fabriziodemaria
commented
Mar 28, 2024
ConfidenceDemoApp/ConfidenceDemoApp.xcodeproj/xcshareddata/xcschemes/ConfidenceDemoApp.xcscheme
Show resolved
Hide resolved
fabriziodemaria
commented
Mar 28, 2024
nicklasl
reviewed
Apr 2, 2024
nicklasl
reviewed
Apr 2, 2024
Sources/ConfidenceProvider/ConfidenceClient/ConfidenceClientOptions.swift
Show resolved
Hide resolved
nicklasl
previously approved these changes
Apr 2, 2024
nicklasl
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing a new
ConfidenceLibrary. The Confidence Library conforms to aConfidenceEventSenderprotocol, allowing the hosting app to emit events to Confidence (implementation of the actual event sending to the backend will be added in following PRs).The change is almost backwards compatible: the user has to add the
Confidencelibrary as a dependency and import, but no change is required in the main code. However, it's totally ok to configure the Provider with the Confidence object, with available configurations:For any other testing-oriented dependency injection, users can still use the current
Builderpattern of the Provider.Note that this PR also includes a very incomplete setup for Contextual and for adding the EvaluationContext to each event. This will be further implemented in following PRs.