fix: change STALE reason in case of context change #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickybondarenko
requested review from
fabriziodemaria,
mfranberg,
vahidlazio and
nicklasl
as code owners
nickybondarenko
force-pushed
the
stale-cache-provider-eval
branch
from
19715f1 to
65649cd
Compare
nickybondarenko
force-pushed
the
stale-cache-provider-eval
branch
from
65649cd to
6d9ec6c
Compare
vahidlazio
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the provider would emit STALE if the evaluation context changed and the cache has been populated with default values due to fetch request not being finished. We believe that trying to access cache too early is an error on the user's side and should be communicated as an ERROR and not STALE.