fix: change STALE reason in case of context change

spotify · Feb 8, 2024 · 6d9ec6c · 6d9ec6c
1 parent aefe8ab
commit 6d9ec6c
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/Sources/ConfidenceProvider/ConfidenceFeatureProvider.swift b/Sources/ConfidenceProvider/ConfidenceFeatureProvider.swift
@@ -251,8 +251,12 @@ public class ConfidenceFeatureProvider: FeatureProvider {
             )
             return evaluationResult
         } catch ConfidenceError.cachedValueExpired {
-            return ProviderEvaluation(value: defaultValue, variant: nil, reason: Reason.stale.rawValue)
-        } catch {
+            return ProviderEvaluation(value: defaultValue,
+                                      variant: nil, 
+                                      reason: Reason.error.rawValue,
+                                      errorCode: ErrorCode.providerNotReady
+            )}
+        catch {
             throw error
         }
     }

diff --git a/Tests/ConfidenceProviderTests/ConfidenceFeatureProviderTest.swift b/Tests/ConfidenceProviderTests/ConfidenceFeatureProviderTest.swift
@@ -347,10 +347,10 @@ class ConfidenceFeatureProviderTest: XCTestCase {
                 context: MutableContext(targetingKey: "user1"))
 
             XCTAssertEqual(evaluation.value, 0)
-            XCTAssertNil(evaluation.errorCode)
             XCTAssertNil(evaluation.errorMessage)
             XCTAssertNil(evaluation.variant)
-            XCTAssertEqual(evaluation.reason, Reason.stale.rawValue)
+            XCTAssertEqual(evaluation.errorCode, ErrorCode.providerNotReady)
+            XCTAssertEqual(evaluation.reason, Reason.error.rawValue)
             XCTAssertEqual(MockedConfidenceClientURLProtocol.resolveStats, 1)
 
             // TODO: Check this - how do we check for something not called?