[READY] - set starttime, check status of api query, and resize header.png #64

sarcasticadmin · 2024-03-01T20:22:16Z

Description of PR

Relates to: #63 #60

Working with @carlynlee and we were having some trouble getting the sign to render the by forcing the datetime: ?year=2024&month=3&day=14&hour=9&minute=30 realized that the starttime was still set to 20x(2023).

There were also some issues with the new header being too large and monopolizing the sign.

Previous Behavior

starttime was set for 20x
21x header.png was not proper size
twitter api call was assumed to always work
missing hr-image.png was causing an error in page render

New Behavior

starttime set to 21x
21x header.png resize to expect size ~360x170px
twitter api call conditional
hr-image.png added back which makes a wave pattern in the middle of the divider between schedule and sponsors

Tests

Sign renders as it should locally
Setting time to: http://192.168.121.161/?year=2024&month=3&day=14&hour=9&minute=29 and schedule matches: https://www.socallinuxexpo.org/scale/21x/schedule/thursday
Setting time to: http://192.168.121.161/?year=2024&month=3&day=14&hour=9&minute=30 and first presentation: In-Progress until 10:30 am Tom Bereknyei A Quick Introduction to Nix Room 106
No error for hr-image.png in browser inspection tools

Previous this was removed during 17x. We could remove this ultimately but since theres css that was erroring it out Ive temporarily added it back in. It provides a small wave pattern on the gray bar that divides the schedule and the sponsors/tweet space

Since spring forward happens before Scale 21x 3/10/24 we dont have to worry about doing anything odd with the timestamp. We can set this to midnight the day of the show.

kylerisse

this all looks good to me @sarcasticadmin . Appreciate all your work and taking over this application. Looking forward to hacking on some of it with you in a couple of weeks.

kylerisse · 2024-03-01T21:07:32Z

README.md


 ### Yearly Tasks

 There is a bit of manual effort necessary from year to year. These tasks include, but might not be limitted to:
-* update the logo for the curent year at `/server/images/header.png`
+* update the logo for the curent year at `/server/images/header.png` should be `360x170px`


new one is 381x170. probably close enough given transparency

I noticed this too. I believe it was due to: convert header.png -resize 360x170^ new.png where ^ allows for some play given the original file since I didnt want to distort it.

It looks good regardless :)

kylerisse · 2024-03-01T21:07:41Z

README.md

@@ -71,14 +71,15 @@ This is available in both Schedule and Room views
 examples: 
 * `http://signs.scale.lan/?year=2019&month=3&day=7&hour=9&minute=10`
 * `http://signs.scale.lan/?room=ballroom-de&year=2019&month=3&day=8&hour=14&minute=33`
+> **NOTE:** This will not work unless `$starttime` is correctly set for the current year of the show


thanks for clarify this

kylerisse · 2024-03-01T21:07:54Z

README.md

 * Do a search and replace for the previous scale version (example: replace all occurances of 16x with 17x)
 * verify proper XML is being supplied by drupal from the url reflected in the `$url` variable in `room.php` and `scroll.php`
-* set `$starttime` in `scroll.php` which should reflect midnight of the first night of current year show
+* set `$starttime` in `scroll.php` which should reflect midnight of the first night of current year show. Example: if the show starts on 3/14/24, then the entry for startime should be: `$starttime = mktime(0, 0, 0, 3, 14, 2024) / 60;`.


thanks for clarifying this

kylerisse · 2024-03-01T21:08:23Z

server/scroll.php

 # before "spring forward"
-#$starttime = mktime(0, 0, 0, 3, 5, 2020) / 60;
-#$starttime = mktime(0, 0, 0, 3, 9, 2023) / 60;

 # after "spring forward"
-# 18x
-#$starttime = mktime(23, 0, 0, 3, 4, 2020) / 60;
-# 19x starts 7/27/2022 23:00
-#$starttime = mktime(23, 0, 0, 7, 27, 2022) / 60;
-# 20x
-$starttime = mktime(23, 0, 0, 3, 8, 2023) / 60;
+# 21x
+$starttime = mktime(0, 0, 0, 3, 14, 2024) / 60;


no more cruft

kylerisse · 2024-03-01T21:10:25Z

server/twitter.php

+
+  # ensure twitter response actually contains statuses
+  # TODO: fix broken query due to upstream changes
+  if (array_key_exists('statuses', $results)) {


thanks for wrapping this.

sarcasticadmin · 2024-03-01T21:19:02Z

Thanks @kylerisse, looking forward to the show!

owendelong · 2024-03-01T23:06:27Z

Couldn’t we force the size of the png render to that value in the rendering html, eliminating the need to worry about the png dimensions? Admittedly there are possible aspect ratio problems introduced by this, but I think a squashed/stretched png in the right form factor is preferable to the alternative. OwenOn Mar 1, 2024, at 13:18, Robert James Hernandez ***@***.***> wrote: @sarcasticadmin commented on this pull request. In README.md:

### Yearly Tasks There is a bit of manual effort necessary from year to year. These tasks include, but might not be limitted to: -* update the logo for the curent year at `/server/images/header.png` +* update the logo for the curent year at `/server/images/header.png` should be `360x170px` I noticed this too. I believe it was due to: convert header.png -resize 360x170^ new.png where ^ allows for some play given the original file since I didnt want to distort it. It looks good regardless :) —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

sarcasticadmin · 2024-03-02T17:11:54Z

Couldn’t we force the size of the png render to that value in the rendering html, eliminating the need to worry about the png dimensions? Admittedly there are possible aspect ratio problems introduced by this, but I think a squashed/stretched png in the right form factor is preferable to the alternative.

@owendelong Absolutely, its just not been a priority

owendelong · 2024-03-07T00:34:36Z

Seems like adding two parameters to the IMG tag would be a lot easier than the hoops we've been jumping through.

sarcasticadmin added 4 commits March 1, 2024 20:07

images: resize 21x header logo to 360x170

9126792

images: add back hr-image1.png

7fd3d84

Previous this was removed during 17x. We could remove this ultimately but since theres css that was erroring it out Ive temporarily added it back in. It provides a small wave pattern on the gray bar that divides the schedule and the sponsors/tweet space

scroll.php: set starttime to 00:00 3/14/24

9817579

Since spring forward happens before Scale 21x 3/10/24 we dont have to worry about doing anything odd with the timestamp. We can set this to midnight the day of the show.

twitter.php: make sure we check statuses from api reponse

995f72e

sarcasticadmin requested a review from kylerisse March 1, 2024 20:22

readme: adding some hints to the readme

2887ab1

sarcasticadmin mentioned this pull request Mar 1, 2024

Twitter/X API functionality #60

Open

kylerisse approved these changes Mar 1, 2024

View reviewed changes

kylerisse merged commit 2c23457 into master Mar 1, 2024
2 checks passed

kylerisse deleted the rh/1709318345 branch March 1, 2024 21:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[READY] - set starttime, check status of api query, and resize header.png #64

[READY] - set starttime, check status of api query, and resize header.png #64

sarcasticadmin commented Mar 1, 2024 •

edited

Loading

kylerisse left a comment

kylerisse Mar 1, 2024

sarcasticadmin Mar 1, 2024

kylerisse Mar 1, 2024

kylerisse Mar 1, 2024

kylerisse Mar 1, 2024

kylerisse Mar 1, 2024

sarcasticadmin commented Mar 1, 2024

owendelong commented Mar 1, 2024 via email

sarcasticadmin commented Mar 2, 2024

owendelong commented Mar 7, 2024

[READY] - set starttime, check status of api query, and resize header.png #64

[READY] - set starttime, check status of api query, and resize header.png #64

Conversation

sarcasticadmin commented Mar 1, 2024 • edited Loading

Description of PR

Previous Behavior

New Behavior

Tests

kylerisse left a comment

Choose a reason for hiding this comment

kylerisse Mar 1, 2024

Choose a reason for hiding this comment

sarcasticadmin Mar 1, 2024

Choose a reason for hiding this comment

kylerisse Mar 1, 2024

Choose a reason for hiding this comment

kylerisse Mar 1, 2024

Choose a reason for hiding this comment

kylerisse Mar 1, 2024

Choose a reason for hiding this comment

kylerisse Mar 1, 2024

Choose a reason for hiding this comment

sarcasticadmin commented Mar 1, 2024

owendelong commented Mar 1, 2024 via email

sarcasticadmin commented Mar 2, 2024

owendelong commented Mar 7, 2024

sarcasticadmin commented Mar 1, 2024 •

edited

Loading