Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[python/ci] Build wheel from sdist outside of Git repository #2589

Merged
merged 1 commit into from
May 20, 2024
Merged

[python/ci] Build wheel from sdist outside of Git repository #2589

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions .github/workflows/python-ci-packaging.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ on:
- 'apis/python/MANIFEST.in'
- 'apis/python/pyproject.toml'
- 'apis/python/setup.py'
- 'apis/python/version.py'
- 'apis/python/src/tiledbsoma/__init__.py'
- 'libtiledbsoma/cmake/inputs/Config.cmake.in'
- 'libtiledbsoma/cmake/inputs/tiledbsoma.pc.in'
Expand All @@ -23,6 +24,7 @@ on:
- 'apis/python/MANIFEST.in'
- 'apis/python/pyproject.toml'
- 'apis/python/setup.py'
- 'apis/python/version.py'
- 'apis/python/src/tiledbsoma/__init__.py'
- 'libtiledbsoma/cmake/inputs/Config.cmake.in'
- 'libtiledbsoma/cmake/inputs/tiledbsoma.pc.in'
Expand Down Expand Up @@ -351,6 +353,7 @@ jobs:
steps:
- uses: actions/checkout@v4
with:
path: TileDB-SOMA
fetch-depth: 0 # for setuptools-scm
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noting, fetch-depth: 0 shouldn't be necessary anymore (since #2563). Fine to leave it in as well.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree it isn't strictly necessary. But I want to keep this test job as close to as possible to the upstream official packaging job that it is designed to emulate

TileDB-SOMA/.github/workflows/python-packaging.yml

Lines 27 to 30 in 6108f73

- name: Checkout TileDB-SOMA
uses: actions/checkout@v3
with:
fetch-depth: 0 # ensure we get all tags to inform package version determination

- name: Setup Python
uses: actions/setup-python@v5
Expand All @@ -360,12 +363,12 @@ jobs:
run: python -m pip install --prefer-binary pybind11 wheel
- name: Build source tarball (sdist)
run: |
cd apis/python
cd TileDB-SOMA/apis/python
python setup.py sdist
- name: Extract source tarball
run: |
tar --list -f apis/python/dist/tiledbsoma-*.tar.gz
tar -xzf apis/python/dist/tiledbsoma-*.tar.gz
tar --list -f TileDB-SOMA/apis/python/dist/tiledbsoma-*.tar.gz
tar -xzf TileDB-SOMA/apis/python/dist/tiledbsoma-*.tar.gz
- name: Build wheel
run: |
cd tiledbsoma-*/
Expand Down
Loading