Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NEW: Static methods replaced with non-static singleton pattern. #55

Merged
merged 1 commit into from
Mar 28, 2022
Merged

NEW: Static methods replaced with non-static singleton pattern. #55

merged 1 commit into from
Mar 28, 2022

Conversation

mfendeksilverstripe
Copy link
Collaborator

@mfendeksilverstripe mfendeksilverstripe commented Mar 23, 2022 •
edited
Loading

NEW: Static methods replaced with non-static singleton pattern.

  • Static methods replaced with non-static singleton pattern
  • Minor code cleanup of in-memory cache but still left it disabled

Out of scope of this PR

  • Raw queries
  • Deep integration

These will be covered separate change-sets

Related issues

#51

@mfendeksilverstripe mfendeksilverstripe added the enhancement New feature or request label Mar 23, 2022
@mfendeksilverstripe mfendeksilverstripe mentioned this pull request Mar 23, 2022
Merged
@mfendeksilverstripe mfendeksilverstripe changed the base branch from bugfix/basic-cleanup to 1 March 25, 2022 00:42
@mfendeksilverstripe mfendeksilverstripe mentioned this pull request Mar 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blueo blueo Awaiting requested review from blueo

@chrispenny chrispenny Awaiting requested review from chrispenny

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mfendeksilverstripe