NEW: Code cleanup (tests, linting). #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfendeksilverstripe
force-pushed
the
bugfix/basic-cleanup
branch
from
52c6bef to
c9f8cc9
Compare
blueo
reviewed
Mar 23, 2022
src/Snapshot.php
Outdated
| 'ObjectHash' => $this->OriginHash, | ||
| ])->first(); | ||
| $item = $this->Items() | ||
| ->filter([ |
There was a problem hiding this comment.
Yes, good find 👍 , I'll make the change.
| } | ||
|
|
||
| /** | ||
| * @return RelationDiffer[] | ||
| * @todo Memoise / cache |
There was a problem hiding this comment.
[nitpick] memoise is a thing: https://en.wikipedia.org/wiki/Memoization
| { | ||
| list($a1, $a2, $a1Block1, $a1Block2, $a2Block1, $gallery1, $gallery2) = $this->buildState(); |
There was a problem hiding this comment.
is it necessary to destructure all the array items even thought you only use $a1?
There was a problem hiding this comment.
I left this intact but I might need to clean this one up as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NEW: Code cleanup (tests, linting).
Out of scope of this PR
These will be covered separate change-sets
Related issues
#51