Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNT Fix unit test #1336

Merged
merged 1 commit into from
Oct 15, 2024
Merged

MNT Fix unit test #1336

merged 1 commit into from
Oct 15, 2024

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Oct 14, 2024 •
edited
Loading

Issue #1338

Unit test was messy so tidied up formatting

What was actually fixed was changing the expected "valid emails" from ['broken@email', '[email protected]'], to [ '[email protected]'], i.e. broken@email was being counted as valid before, which seems completely wrong

@emteknetnz emteknetnz mentioned this pull request Oct 14, 2024
Open
10 tasks
@emteknetnz emteknetnz marked this pull request as draft October 14, 2024 22:06
@emteknetnz emteknetnz mentioned this pull request Oct 15, 2024
Closed
@emteknetnz emteknetnz marked this pull request as ready for review October 15, 2024 01:41
GuySartorelli
GuySartorelli approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is almost certainly related to the recent changes to use symfony validation logic. broken@email was probably valid using one of the old RFCs that we had regex for.

LGTM.

@GuySartorelli
Copy link
Member

GuySartorelli commented Oct 15, 2024 •
edited
Loading

Just running CI against the 6 branch to validate it's not a problem there so we don't find and fix this twice. If that goes green I'll merge.

@GuySartorelli GuySartorelli merged commit 4f821d1 into silverstripe:7 Oct 15, 2024
13 checks passed
@GuySartorelli GuySartorelli deleted the pulls/7/field-validators branch October 15, 2024 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli