Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken unit test #1338

Closed
emteknetnz opened this issue Oct 15, 2024 · 1 comment
Closed

Broken unit test #1338

emteknetnz opened this issue Oct 15, 2024 · 1 comment
Assignees
@GuySartorelli

Comments

@emteknetnz
Copy link
Member

emteknetnz commented Oct 15, 2024 •
edited by GuySartorelli
Loading

https://github.com/silverstripe/recipe-kitchen-sink/actions/runs/11318774193/job/31473863278

 1) SilverStripe\UserForms\Tests\Control\UserDefinedFormControllerTest::testValidEmailsToArray with data set #3 (['broken@email', '[email protected]'], [', broken@email, [email protected],'])
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
 Array (
-    0 => 'broken@email'
-    1 => '[email protected]'
+    0 => '[email protected]'
 )

PR
@emteknetnz emteknetnz self-assigned this Oct 15, 2024
@emteknetnz emteknetnz mentioned this issue Oct 15, 2024
Merged
@emteknetnz emteknetnz removed their assignment Oct 15, 2024
@GuySartorelli GuySartorelli self-assigned this Oct 15, 2024
@GuySartorelli
Copy link
Member

PR merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GuySartorelli GuySartorelli

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@emteknetnz @GuySartorelli