Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX Short-array syntax for Enum #10877

Merged
merged 1 commit into from
Jul 20, 2023
Merged

FIX Short-array syntax for Enum #10877

merged 1 commit into from
Jul 20, 2023

Conversation

emteknetnz
Copy link
Member

Issue #10435

Re the just deleting $arrayValue as noted in the original issue, it's used for specs such as HTMLFragment(['whitelist' => ['meta', 'link']]) so we need to retain it

@emteknetnz emteknetnz mentioned this pull request Jun 23, 2023
Closed
@emteknetnz emteknetnz force-pushed the pulls/4.13/short-array-enum branch 2 times, most recently from 2845be2 to b55a6a0 Compare July 20, 2023 04:04
GuySartorelli
GuySartorelli approved these changes Jul 20, 2023
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuySartorelli GuySartorelli merged commit ec99be0 into silverstripe:4.13 Jul 20, 2023
11 checks passed
@GuySartorelli GuySartorelli deleted the pulls/4.13/short-array-enum branch July 20, 2023 04:41
@emteknetnz emteknetnz mentioned this pull request Jul 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli