Fieldspec Enum(["value1","value2"]) does not work

[ntd]

Present in Silverstripe 4.9 and 4.11: see this forum thread for a real world example of this issue.

Defining a field with the above spec throws the following error:

[Emergency] Uncaught SilverStripe\ORM\Connect\DatabaseException: Couldn't run query: ALTER TABLE ... ADD ... enum() 

The same fieldspec in different formats works fine:

static private $db = [
    `throw-error` => 'Enum(["Value1", "Value2"])',
    'works'       => 'Enum(array("Value1", "Value2"))',
    'also-works'  => 'Enum("Value2, Value2")',
];

After investigating, it seems the array part in the first syntax is stripped away by the following code in DBSchemaManager.php

                //Is this an array field?
                $arrayValue = '';
                if (strpos($fieldSpec ?? '', '[') !== false) {
                    //If so, remove it and store that info separately
                    $pos = strpos($fieldSpec ?? '', '[');
                    $arrayValue = substr($fieldSpec ?? '', $pos ?? 0);
                    $fieldSpec = substr($fieldSpec ?? '', 0, $pos);
                }

                /** @var DBField $fieldObj */
                $fieldObj = Injector::inst()->create($fieldSpec, $fieldName);
                $fieldObj->setArrayValue($arrayValue);

No idea what that $arrayValue is used for, but after removing the if branch dev/build succeeded.

PRs

• FIX Short-array syntax for Enum #10877

[xini]

also see silverstripe/developer-docs#288

[GuySartorelli]

PR merged. It'll be tagged automatically as 4.13.12 once the merge CI is green.