Pulls/4.0/5464 duplicate campaign name #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phalkunz
force-pushed
the
pulls/4.0/5464-duplicate-campaign-name
branch
3 times, most recently
from
3b75f3e
to
6e357c5
Compare
4 tasks
flamerohr
suggested changes
May 9, 2017
src/CampaignAdmin.php
Outdated
|
|
||
| $message = _t('LeftAndMain.SAVEDUP', 'Saved.'); | ||
| $hasExistingName = Changeset::get() | ||
| ->filter('Name:case', $data['Name']) |
There was a problem hiding this comment.
I would opt for case-insensitivity when filtering for a duplicate.
Having an entry My case and allowing for My Case to also be created is going to be confusing.
Was this discussed to have it case-sensitive?
There was a problem hiding this comment.
No, it wasn't in any discussion. I thought it was a good idea but in hindsight it is rather confusing. Good spotting it :)
phalkunz
force-pushed
the
pulls/4.0/5464-duplicate-campaign-name
branch
from
6e357c5
to
40546cc
Compare
flamerohr
approved these changes
May 9, 2017
dnsl48
pushed a commit
to creative-commoners/silverstripe-campaign-admin
that referenced
this pull request
Oct 29, 2020
Add PHP7 + SS3.6 build to Travis configuration and fix build badge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: silverstripe/silverstripe-framework#5464