Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Don't allow multiple campaigns with the same name #5464

Closed
4 tasks done
clarkepaul opened this issue May 6, 2016 · 5 comments
Closed
4 tasks done

Enhancement: Don't allow multiple campaigns with the same name #5464

clarkepaul opened this issue May 6, 2016 · 5 comments

Comments

@clarkepaul
Copy link
Contributor

clarkepaul commented May 6, 2016

Acceptance criteria

  • Campaigns are easily distinguish without careful naming from the user
    • De-duplicate
    • Maybe auto-affix a creation date?
    • Maybe allow campaigns without a name identified solely by a date

Set-on-form-submission is fine.


There is no indication that there is already a campaign with the same name.

pasted_image_6_05_16__2_19_pm

Tasks

  • If a name exists show an error message in the form
  • Handle name duplicate in edit form
  • Do not redirect use to campaign edit form if there's an error in the form submission response

Related

Pull requests

@stevie-mayhew
Copy link
Contributor

Do we want to allow campaigns with the same name and instead attribute a date as part of their title? I know its a bit finicky, but I can see a use for multiple campaigns with the same name (even if we wouldn't do it ourselves)

@clarkepaul
Copy link
Contributor Author

Yup possibly, or just a incremental numbering after the title as in the files area and most computers handling duplications.

@chillu
Copy link
Member

chillu commented May 11, 2016

In general, we need to visualise validation feedback, which means we need the mechanisms for server and client validations in the first place - I've created some cards: #5523 and #5522

@clarkepaul clarkepaul added this to the CMS 4.0.0-beta1 milestone Dec 20, 2016
@phalkunz
Copy link
Contributor

phalkunz commented May 3, 2017

Wouldn't it make more sense to suffix a campaign name with -v{n} where n is integer when the name already exists? We already have this behaviour in Asset Admin.

@clarkepaul
Copy link
Contributor Author

Eventually there will be more fields for which a user can distinguish the difference between campaigns (due date, date created, permissions) so I think a suffix would work good as the most basic step. A message notifying the user that the given name already exists before providing the suggested suffixed name would make a nice addition.

"That name is already taken. You could use... "

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants