Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test expansion and (more) bug-fixes 🔧 🔥 #27

Merged
merged 3 commits into from
Jul 1, 2024
Merged

Commits on Jun 29, 2024

  1. Expanded Test and bug-fix 🔥 🔥

    The code coverage now covers all exchanges that can be run in the US. A minor bug-fix on Huobi FUTURES have been fixed in the process.
    serkor1 committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    af9f149 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2024

  1. Bug-fixes and Test-Expansion 🔧

    The test-getQuote.R has been expanded to include ALL intervals. The get_quote()-function
    has been wrapped in try() as testthat doesn't capture the error per se.
    
    Various bugs have been captured in this process:
    
    1. Binance Futures doesn't have a 1s interval.
    2. Bitmart doesn't have a 3m, 6h or 3d interval. However, the
    documentation clearly states that it has. The URLs have been pasted directly
    into the browser to verify this - its a but on their side.
    
    Note:
    
    This commit closes #26
    serkor1 committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    d527349 View commit details
    Browse the repository at this point in the history
  2. See d527349 ℹ️

    This commit is a conflict-resultion commit and push. The original commit is d527349
    serkor1 committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    c3743aa View commit details
    Browse the repository at this point in the history