Test expansion and (more) bug-fixes 🔧 🔥 #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code coverage now covers all exchanges that can be run in the US. A minor bug-fix on Huobi FUTURES have been fixed in the process.
The test-getQuote.R has been expanded to include ALL intervals. The get_quote()-function has been wrapped in try() as testthat doesn't capture the error per se. Various bugs have been captured in this process: 1. Binance Futures doesn't have a 1s interval. 2. Bitmart doesn't have a 3m, 6h or 3d interval. However, the documentation clearly states that it has. The URLs have been pasted directly into the browser to verify this - its a but on their side. Note: This commit closes #26
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test-getQuote.R has been expanded to include ALL intervals. The get_quote()-function
has been wrapped in try() as testthat doesn't capture the error per se.
Various bugs have been captured in this process:
documentation clearly states that it has. The URLs have been pasted directly
into the browser to verify this - its a but on their side.