Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add customerType tag #149

Merged
merged 1 commit into from
Aug 27, 2024
Merged

add customerType tag #149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified app-debug.apk
View file
Open in desktop
Binary file not shown.
Binary file modified app-release.apk
View file
Open in desktop
Binary file not shown.
4 changes: 2 additions & 2 deletions app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,8 @@ android {
applicationId "com.example.vu.android"
minSdkVersion 21
targetSdkVersion 29
versionCode 46
versionName "2.11.0"
versionCode 47
versionName "2.11.1"

testInstrumentationRunner = "androidx.test.runner.AndroidJUnitRunner"
externalNativeBuild {
Expand Down
1 change: 0 additions & 1 deletion app/src/main/java/com/example/vu/android/MainActivity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ protected void onCreate(Bundle savedInstanceState) {
// SENTRY Tag and Breadcrumb
String activity = this.getClass().getSimpleName();
Sentry.setTag("activity", activity);
Sentry.setTag("customerType", "enterprise");
Copy link
Contributor Author

@sdzhong sdzhong Aug 27, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed explicit customerType = enterprise tag from MainActivity transaction only


Breadcrumb breadcrumb = new Breadcrumb();
breadcrumb.setMessage("Android activity was created");
Expand Down
3 changes: 3 additions & 0 deletions app/src/main/java/com/example/vu/android/MyApplication.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,9 @@
});
});

String[] allCustomerTypes = {"medium-plan", "large-plan", "small-plan", "enterprise"};
String customerType = allCustomerTypes[(int) (Math.random() * 4)];
Sentry.setTag("customerType", customerType);

Check warning on line 116 in app/src/main/java/com/example/vu/android/MyApplication.java

View check run for this annotation

Codecov / codecov/patch

app/src/main/java/com/example/vu/android/MyApplication.java#L114-L116 

Added lines #L114 - L116 were not covered by tests
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

customerType added to SentryAndroid.init()

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: other events also have their associated customerType
image

Sentry.setTag("se", SE);

// Set User info on Sentry event using a random email
Expand Down
Binary file modified release/app-release.apk
View file
Open in desktop
Binary file not shown.
Loading