add customerType tag #149
Merged
add customerType tag #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdzhong
commented
Aug 27, 2024
| @@ -29,7 +29,6 @@ protected void onCreate(Bundle savedInstanceState) { | |||
| // SENTRY Tag and Breadcrumb | |||
| String activity = this.getClass().getSimpleName(); | |||
| Sentry.setTag("activity", activity); | |||
| Sentry.setTag("customerType", "enterprise"); | |||
There was a problem hiding this comment.
Removed explicit customerType = enterprise tag from MainActivity transaction only
sdzhong
commented
Aug 27, 2024
| @@ -111,6 +111,9 @@ public void onCreate() { | |||
| }); | |||
| }); | |||
|
|
|||
| String[] allCustomerTypes = {"medium-plan", "large-plan", "small-plan", "enterprise"}; | |||
| String customerType = allCustomerTypes[(int) (Math.random() * 4)]; | |||
| Sentry.setTag("customerType", customerType); | |||
There was a problem hiding this comment.
customerType added to SentryAndroid.init()
There was a problem hiding this comment.
Note: other events also have their associated customerType
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #149 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 15 15
Lines 777 771 -6
Branches 43 43
=====================================
+ Misses 777 771 -6 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #129