Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elfloader,RISC-V: Fix early boot issues #136

Merged
merged 1 commit into from
Feb 6, 2022

Conversation

kent-mcleod
Copy link
Member

  • Set a valid stack before calling any C function so that memory and
    registers don't get corrupted.
  • Keep track of the DTB address so that it's still in a1 when main is
    called even if we needed to switch to a different HART.
  • If the HSM extention isn't present, then try and call main on the
    current HART.
  • Suspend HARTs that exceed CONFIG_MAX_NUM_NODES.

Signed-off-by: Kent McLeod [email protected]

@kent-mcleod
Copy link
Member Author

Fixes #84

@lsf37
Copy link
Member

lsf37 commented Feb 4, 2022

Thanks for separating that out, much easier to review.

lsf37 added a commit to seL4/ci-actions that referenced this pull request Feb 4, 2022
This failure is an elfloader problem, to be fixed in
seL4/seL4_tools#136

Signed-off-by: Gerwin Klein <[email protected]>
Copy link
Member

@axel-h axel-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me to be merged

@lsf37
Copy link
Member

lsf37 commented Feb 4, 2022

Good to merge?

- Set a valid stack before calling any C function so that memory and
  registers don't get corrupted.
- Keep track of the DTB address so that it's still in a1 when main is
  called even if we needed to switch to a different HART.
- If the HSM extention isn't present, then try and call main on the
  current HART.
- Suspend HARTs that exceed CONFIG_MAX_NUM_NODES.

Signed-off-by: Kent McLeod <[email protected]>
@kent-mcleod kent-mcleod merged commit 5fee50c into seL4:master Feb 6, 2022
@kent-mcleod kent-mcleod deleted the kent/patch34 branch February 6, 2022 02:00
lsf37 added a commit to seL4/ci-actions that referenced this pull request Feb 6, 2022
This failure is an elfloader problem, to be fixed in
seL4/seL4_tools#136

Signed-off-by: Gerwin Klein <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug hw-test enable sel4test hardware builds + runs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants