Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

asm code calls clear_bss without a valid stack pointer #84

Closed
axel-h opened this issue Jun 7, 2021 · 2 comments
Closed

asm code calls clear_bss without a valid stack pointer #84

axel-h opened this issue Jun 7, 2021 · 2 comments
Labels
bug

Comments

@axel-h
Copy link
Member

axel-h commented Jun 7, 2021

In #82 we call clear_bss from asm code now when CONFIG_IMAGE_BINARY is enabled - but there is no stack set up. This is a bit dangerous, since C code always assumes there is stack. It may work if the function is simple enough so C does not create a stack frame.
@axel-h axel-h added the bug label Jun 13, 2021
@axel-h axel-h mentioned this issue Feb 2, 2022
Draft
@axel-h
Copy link
Member Author

axel-h commented Feb 2, 2022 •
edited
Loading

This will be fixed when #136 is merged, as a proper stack pointer is set up then.

@kent-mcleod kent-mcleod mentioned this issue Feb 4, 2022
Merged
@kent-mcleod
Copy link
Member

Fixed by #136

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kent-mcleod @axel-h