Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scalardb/cleanup cassandra deps #114

Merged
merged 8 commits into from
Nov 21, 2023
Merged

Scalardb/cleanup cassandra deps #114

merged 8 commits into from
Nov 21, 2023

Conversation

yito88
Copy link
Member

@yito88 yito88 commented Oct 22, 2023 •
edited
Loading

Description

To support other DBs, clean up Cassandra-dependent code and DB-specific code in scalardb

Related issues and/or PRs

#113

Changes made

  • Separate the Cassandra-dependent code
    • Replace cassandra-test with scalardb-test
    • Use ScalarDB schema loder
  • Add abstract DB-specific functions with extend-db

Checklist

The following is a best-effort checklist. If any items in this checklist are not applicable to this PR or are dependent on other, unmerged PRs, please still mark the checkboxes after you have read and understood each item.

  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes.
  • Any remaining open issues linked to this PR are documented and up-to-date (Jira, GitHub, etc.).
  • Tests (unit, integration, etc.) have been added for the changes.
  • My changes generate no new warnings.
  • Any dependent changes in other PRs have been merged and published.

Additional notes (optional)

Provide any additional information or notes that may be relevant to the reviewers or stakeholders.

@yito88 yito88 marked this pull request as ready for review November 4, 2023 15:12
brfrn169
brfrn169 approved these changes Nov 10, 2023
View reviewed changes
Copy link
Contributor

@brfrn169 brfrn169 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

feeblefakie
feeblefakie reviewed Nov 15, 2023
View reviewed changes
Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looking good! Thank you!
Left one question.

scalardb/project.clj Outdated
[cc.qbits/alia "4.3.6"]
[cc.qbits/hayt "4.1.0"]]
[cheshire "5.12.0"]
[com.scalar-labs/scalardb-schema-loader "3.10.1"]]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use 4.0.0-SNAPSHOT instead of the latest released version?

@brfrn169 What do you think?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yes. I think so, too.

feeblefakie
feeblefakie approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@feeblefakie feeblefakie merged commit 83a32c8 into master Nov 21, 2023
3 checks passed
@feeblefakie feeblefakie deleted the scalardb/cleanup-cassandra-deps branch November 21, 2023 01:40
@yito88 yito88 mentioned this pull request Nov 29, 2023
Merged
6 tasks
@komamitsu komamitsu mentioned this pull request Feb 27, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brfrn169 brfrn169 brfrn169 approved these changes

@feeblefakie feeblefakie feeblefakie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yito88 @brfrn169 @feeblefakie