Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cassandra properties #117

Merged
merged 2 commits into from
Dec 4, 2023
Merged

Fix cassandra properties #117

merged 2 commits into from
Dec 4, 2023

Conversation

yito88
Copy link
Member

@yito88 yito88 commented Nov 29, 2023

Description

Cassandra properties doesn't have the contact points. To fix it, nodes parameters are set to the contact points.

Related issues and/or PRs

it happened in #114, but CI passed. (After it was merged, it happened. the schema-loder was changed?)

Changes made

Set (:nodes test) to the contact points

Checklist

he checkboxes after you have read and understood each item.

  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes.
  • Any remaining open issues linked to this PR are documented and up-to-date (Jira, GitHub, etc.).
  • Tests (unit, integration, etc.) have been added for the changes.
  • My changes generate no new warnings.
  • Any dependent changes in other PRs have been merged and published.

Additional notes (optional)

Provide any additional information or notes that may be relevant to the reviewers or stakeholders.

Copy link
Contributor

@inv-jishnu inv-jishnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
I assume the unit test failure will be fixed once this PR is merged.
Thank you,

Copy link
Contributor

@brfrn169 brfrn169 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@brfrn169 brfrn169 merged commit 0d8ff9d into master Dec 4, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants