-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand on our Timestamp mock #39
Conversation
I'm not sure if this change is inlcuded in this changelist (or if it listed somewhere else) but there is an issue in the timestamp implementation:
note A suggested change here: thecointech@9bc4d4a (or I can add this as a PR once the subCollections PR has been merged) |
That's a good point @FrozenKiwi. I believe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! 🙌 Just a couple of comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 Nice work 🙌
Thanks! #40 is ready for review. |
Description
Our mocked
Firebase.Timestamp
class now covers Firestore's API fortoDate
,toMillis
getters, andfromDate
andfromMillis
constructors.The corresponding Jest mock functions may be used to inject return values to these functions, like so:
Related issues
Depends on #38
How to test