Add Transaction mocks #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 4, 2020
Merged
Merged
|
Fixed merge conflicts in firestore.js |
sbatson5
reviewed
Sep 14, 2020
| const mockUpdateTransaction = jest.fn(); | ||
| const mockDeleteTransaction = jest.fn(); | ||
|
|
||
| class Transaction { |
There was a problem hiding this comment.
Should this class also have getAll?
https://googleapis.dev/nodejs/firestore/latest/Transaction.html#getAll
There was a problem hiding this comment.
It definitely should! I must've overlooked that.
The logic for that might be complicated. Could we perhaps add it in another PR after this series is through?
There was a problem hiding this comment.
It's probably just a loop over each provided ref. It shouldn't be too bad to throw that in this branch. Gimme a sec...
There was a problem hiding this comment.
Added in the latest commit. What do you think?
sbatson5
approved these changes
Sep 18, 2020
|
Thanks! #39 is ready for review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We now mock over
Firestore.Transaction. This branch adds mocks (all exported through firestore.js as usual) for the usualfirestore.transactionAPI calls.Related issues
Depends on #37
How to test