Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sdds-serv: add TextArea component #1263

Merged
merged 4 commits into from
Jun 25, 2024
Merged

sdds-serv: add TextArea component #1263

merged 4 commits into from
Jun 25, 2024

Conversation

denivladislav
Copy link
Contributor

@denivladislav denivladislav commented Jun 22, 2024 •
edited by Salute-Eva
Loading

TextArea

  • TextArea портирован в sdds

What/why changed

  • свойство resize помечено как deprecated в библиотеках plasma-{b2c, web}
  • добавлен в sdds-serv
📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
# or 
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]

@github-actions GitHub Actions
Copy link
Contributor

Theme Builder app deployed!

https://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-1263/

@github-actions GitHub Actions
Copy link
Contributor

Documentation preview deployed!

website:https://plasma.sberdevices.ru/pr/pr-1263/
caldera-online storybook: https://plasma.sberdevices.ru/pr/pr-1263/caldera-online-storybook/
asdk storybook: https://plasma.sberdevices.ru/pr/pr-1263/asdk-storybook/
b2c storybook: https://plasma.sberdevices.ru/pr/pr-1263/b2c-storybook/
new-hope storybook: https://plasma.sberdevices.ru/pr/pr-1263/new-hope-storybook/
web storybook: https://plasma.sberdevices.ru/pr/pr-1263/web-storybook/
sdds-serv storybook: https://plasma.sberdevices.ru/pr/pr-1263/sdds-serv-storybook/
ui storybook: https://plasma.sberdevices.ru/pr/pr-1263/ui-storybook/

@github-actions GitHub Actions
Copy link
Contributor

⚡ Component performance testing

Result: 🟢 OK

@denivladislav denivladislav force-pushed the PLASMA-3061/add-textarea-component-to-sdds branch from 2d2842c to 39b712b Compare June 22, 2024 16:42
@github-actions GitHub Actions
Copy link
Contributor

⚡ Component performance testing

Result: 🟢 OK

@denivladislav denivladislav marked this pull request as ready for review June 24, 2024 06:06
@Yakutoc Yakutoc requested a review from simashova June 24, 2024 07:16
neretin-trike
neretin-trike reviewed Jun 24, 2024
View reviewed changes
packages/sdds-serv/src/components/TextArea/TextArea.tsx Outdated
type TextAreaComponentType = ForwardRefExoticComponent<TextAreaProps & RefAttributes<HTMLTextAreaElement>>;

const mergedConfig = mergeConfig(textAreaConfig, config);
const TextAreaComponent = component(mergedConfig) as TextAreaComponentType;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

а здесь точно нужно явное приведение типов? Разве то, что генерирует функция не подойдёт?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Без приведения ловил ошибку ts2742

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

а можешь показать, что за ошибка?

Copy link
Contributor Author

@denivladislav denivladislav Jun 24, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Без каста TextAreaComponentType прилетает ts2742:
The inferred type of 'TextArea' cannot be named without a reference to '../../../../plasma-new-hope/node_modules/@salutejs/plasma-core'. This is likely not portable. A type annotation is necessary.

typeAnnotation.mov

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

а, ну такую проблему мы уже решали

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

в файле plasma/packages/plasma-new-hope/src/components/TextArea/TextArea.types.tsx, вместо импорта из plasma-core, скопируй файл TextareaHTMLAttributes в директорию /plasma/packages/plasma-new-hope/src/types. И добавь в этот файл по аналогии с InputHTMLAttributes (который лежит там же) вот эту инфу:

// INFO: Issue об этом решении - https://github.com/salute-developers/plasma/issues/1219

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@neretin-trike Вопрос на миллион, в b2c/web у нас тоже кастинг -

const TextAreaComponent = component(mergedConfig) as ForwardRefExoticComponent<
    TextAreaProps & RefAttributes<HTMLTextAreaElement>
>;

кастинг - это проблема?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

лучше без него обходиться там, где это возможно. В b2/web это нужно для обратной совместимости

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

поправил

@denivladislav denivladislav requested review from Yakutoc and removed request for shuga2704 June 24, 2024 07:47
@denivladislav denivladislav force-pushed the PLASMA-3061/add-textarea-component-to-sdds branch from 39b712b to 4289336 Compare June 24, 2024 10:17
@github-actions GitHub Actions
Copy link
Contributor

⚡ Component performance testing

Result: 🟢 OK

@denivladislav denivladislav force-pushed the PLASMA-3061/add-textarea-component-to-sdds branch from 4289336 to 626c95a Compare June 24, 2024 14:22
@github-actions GitHub Actions
Copy link
Contributor

⚡ Component performance testing

Result: 🟢 OK

@denivladislav denivladislav force-pushed the PLASMA-3061/add-textarea-component-to-sdds branch from 626c95a to 0b2112e Compare June 25, 2024 09:35
@github-actions GitHub Actions
Copy link
Contributor

⚡ Component performance testing

Result: 🟢 OK

@denivladislav denivladislav added this pull request to the merge queue Jun 25, 2024
Merged via the queue into dev with commit b38568e Jun 25, 2024
29 checks passed
@denivladislav denivladislav deleted the PLASMA-3061/add-textarea-component-to-sdds branch June 25, 2024 10:08
@denivladislav denivladislav mentioned this pull request Jun 25, 2024
Merged
@Salute-Eva Salute-Eva mentioned this pull request Jun 26, 2024
Merged
This was referenced Jul 24, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simashova simashova simashova approved these changes

@neretin-trike neretin-trike neretin-trike approved these changes

@Yakutoc Yakutoc Yakutoc approved these changes

Assignees
No one assigned
Labels
plasma-components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@denivladislav @Yakutoc @neretin-trike @simashova