Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plasma-new-hope: TextArea height / width fixes #1261

Merged
merged 8 commits into from
Jun 25, 2024
Merged

plasma-new-hope: TextArea height / width fixes #1261

merged 8 commits into from
Jun 25, 2024

Conversation

denivladislav
Copy link
Contributor

@denivladislav denivladislav commented Jun 20, 2024 •
edited by Salute-Eva
Loading

TextArea

  • исправлена типизация (разбитие на три группы rows / cols, height / width, autoResize / minAuto / maxAuto)
  • исправлен расчёт autoResize
  • исправлена документация

What/why changed

Правки, связанные с высотой и шириной компонента

Before / after (autoResize)

До:
Пусть minAuto = 1, maxAuto = 1. Пусть написана одна строка текста. Высота textarea в этом случае равна 2rem, что неверно.

before-minAuto1-maxAuto1.mov

После:
Поскольку сейчас minAuto и minAuto отвечают за отображаемое кол-во строк, то высота textarea в этом случае должна быть равна одному line-height (20px для размера m):

after-minAuto1-maxAuto1.mov

После:
Пример для minAuto = 2, maxAuto = 4

after-minAuto2-maxAuto4.mov

После:
Пример для другого размера шрифта:

sExample.mov

После:
Если нет ограничений (minAuto / maxAuto), то высота растёт бесконечно:

after-minAuto0-maxAuto0.mov
📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
# or 
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]

@denivladislav denivladislav added bugs Something isn't working plasma-components labels Jun 20, 2024
@github-actions GitHub Actions
Copy link
Contributor

Theme Builder app deployed!

https://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-1261/

@github-actions GitHub Actions
Copy link
Contributor

Documentation preview deployed!

website:https://plasma.sberdevices.ru/pr/pr-1261/
caldera-online storybook: https://plasma.sberdevices.ru/pr/pr-1261/caldera-online-storybook/
asdk storybook: https://plasma.sberdevices.ru/pr/pr-1261/asdk-storybook/
b2c storybook: https://plasma.sberdevices.ru/pr/pr-1261/b2c-storybook/
new-hope storybook: https://plasma.sberdevices.ru/pr/pr-1261/new-hope-storybook/
web storybook: https://plasma.sberdevices.ru/pr/pr-1261/web-storybook/
sdds-serv storybook: https://plasma.sberdevices.ru/pr/pr-1261/sdds-serv-storybook/
ui storybook: https://plasma.sberdevices.ru/pr/pr-1261/ui-storybook/

@github-actions GitHub Actions
Copy link
Contributor

⚡ Component performance testing

Result: 🟢 OK

@denivladislav denivladislav force-pushed the PLASMA-2337/textarea-height-width-fixes branch from 689bcfc to 865e768 Compare June 20, 2024 11:19
@github-actions GitHub Actions
Copy link
Contributor

⚡ Component performance testing

Result: 🟢 OK

@denivladislav denivladislav requested review from Yakutoc, iljs and Yeti-or and removed request for Yeti-or June 20, 2024 12:00
@denivladislav denivladislav marked this pull request as ready for review June 20, 2024 12:07
denivladislav
denivladislav commented Jun 25, 2024
View reviewed changes
website/sdds-serv-docs/docs/components/TextArea.mdx Outdated
Copy link
Contributor Author

@denivladislav denivladislav Jun 25, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

апдейтнул доку sdds в связи с влитием #1263

relative link:
#1263 (comment)

@denivladislav denivladislav force-pushed the PLASMA-2337/textarea-height-width-fixes branch from cd5bb26 to c159cae Compare June 25, 2024 12:16
@github-actions GitHub Actions
Copy link
Contributor

⚡ Component performance testing

Result: 💀 WASTED

Performance tests are broken.
If the current changes are the cause, please fix it immediately in this PR. If not, please schedule their repair.
For any questions, come to the Speed team.

@denivladislav denivladislav force-pushed the PLASMA-2337/textarea-height-width-fixes branch from c159cae to 03507e1 Compare June 25, 2024 12:30
@github-actions GitHub Actions
Copy link
Contributor

⚡ Component performance testing

Result: 💀 WASTED

Performance tests are broken.
If the current changes are the cause, please fix it immediately in this PR. If not, please schedule their repair.
For any questions, come to the Speed team.

@github-actions GitHub Actions
Copy link
Contributor

⚡ Component performance testing

Result: 💀 WASTED

Performance tests are broken.
If the current changes are the cause, please fix it immediately in this PR. If not, please schedule their repair.
For any questions, come to the Speed team.

@github-actions GitHub Actions
Copy link
Contributor

⚡ Component performance testing

Result: 🟢 OK

@denivladislav denivladislav added this pull request to the merge queue Jun 25, 2024
Merged via the queue into dev with commit 23bbdb9 Jun 25, 2024
29 checks passed
@denivladislav denivladislav deleted the PLASMA-2337/textarea-height-width-fixes branch June 25, 2024 14:13
@Salute-Eva Salute-Eva mentioned this pull request Jun 26, 2024
Merged
@Yakutoc Yakutoc mentioned this pull request Jul 11, 2024
Merged
This was referenced Jul 24, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iljs iljs iljs approved these changes

@neretin-trike neretin-trike neretin-trike approved these changes

@Yakutoc Yakutoc Yakutoc approved these changes

Assignees

@denivladislav denivladislav

Labels
bugs Something isn't working plasma-components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@denivladislav @Yakutoc @neretin-trike @iljs