Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHP 8.4 support #1556

Merged
merged 2 commits into from
Jul 29, 2024
Merged

Add PHP 8.4 support #1556

merged 2 commits into from
Jul 29, 2024

Conversation

cedric-anne
Copy link
Contributor

@cedric-anne cedric-anne commented Jul 29, 2024

Related issue sabre-io/event#123

Copy link

codecov bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.24%. Comparing base (c327c0f) to head (a9d0a90).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1556   +/-   ##
=========================================
  Coverage     97.24%   97.24%           
  Complexity     2834     2834           
=========================================
  Files           175      175           
  Lines          8843     8843           
=========================================
  Hits           8599     8599           
  Misses          244      244           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I will adjust the CI again in a later PR so that it will effectively run phpstan to find the deprecations.

@phil-davis phil-davis merged commit fd570dc into sabre-io:master Jul 29, 2024
10 checks passed
@cedric-anne
Copy link
Contributor Author

Thanks. I will adjust the CI again in a later PR so that it will effectively run phpstan to find the deprecations.

In the latest PHP-CS-fixer version (I did not check the previous versions), it is possible to define the following rules, in order to detect/fix the nullable marker:

        'nullable_type_declaration' => [
            'syntax' => 'question_mark',
        ],
        'nullable_type_declaration_for_default_null_value' => true,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants