PHP 8.4 compliance

[cedric-anne]

We are currently using the sabre/dav in an open source project and we want to make it fully compliant with PHP 8.4, and we cannot upgrade to sabre/event:^6.0 because sabre/dav is not compatible with it.

If we provide a patch for it, would you accept to integrate it in a new 5.1.5 version ?

There is at least the following deprecation to fix:

Deprecated: Sabre\Event\Loop\instance(): Implicitly marking parameter $newLoop as nullable is deprecated, the explicit nullable type must be used instead in /var/www/glpi/vendor/sabre/event/lib/Loop/functions.php on line 133

[staabm]

I think these deprecations should be fixed with cs fixer over the whole codebase (maybe also other sabre/* repos).
since fixing this error is backwards compatible we could do it in the older versions 👍

[phil-davis]

PR #124 - I tried running the analysis tools in master with PHP 8.4. There are lots of vendor dependencies that need these deprecations adjusted.

I will also try in the major version 5 branch - that at least might show me the adjustment needed to the Event code (and lots of other vendor dependency issues!)

[cedric-anne]

maybe also other sabre/* repos

I confirm that it affects multiple sabre/* components we use.

[phil-davis]

I will link all the various related PRs to this issue, and keep the issue open until all PHP 8.4 compliance has been done.

[phil-davis]

These repos have been updated:

• event see PR [5.1] Add PHP 8.4 to CI #126 and release https://github.com/sabre-io/event/releases/tag/5.1.5
• xml see PR Add PHP 8.4 compliance for 2.2 branch xml#285 and release https://github.com/sabre-io/xml/releases/tag/2.2.8
• uri see PR Add PHP 8.4 to CI for v2 branch uri#116 - no release needed, it "just works"
• http see PR chore: add PHP 8.4 to CI of 5.1 branch http#241 and release https://github.com/sabre-io/http/releases/tag/5.1.11
• vobject Released in https://github.com/sabre-io/vobject/releases/tag/4.5.6
• dav https://github.com/sabre-io/dav/releases/tag/4.7.0
• cache see PR chore: add PHP 8.4 to CI cache#69 - no release needed

[staabm]

Just want to say thank you ❤️ for working thru all the repo @phil-davis

[phil-davis]

Also to-do is to forward-port code changes from the old major-version branches in each repo to the later (current...) branches and release PHP 8.4 compatible code in those branches.

[phil-davis]

I have got all the various major release branches of the "small" repos up-to-date with all the tools (cs-fixer, phpstan) and with CI running PHP 8.4, and releases done.
So event, http, xml and uri are done.
And cache https://github.com/sabre-io/cache/releases/tag/2.0.2

Now that they all pass cleanly, I will move on to getting the CI sorted out for vobject, and make releases for each major branch of that. And then do the same for "dav" (which is at the top of the dependency tree).

[nickvergessen]

• vobject

• Progress in chore: add PHP 8.4 to CI [4.5] vobject#662

• dav

• Was done in Add PHP 8.4 support dav#1556 but needs releasing (after vobject I guess)

[phil-davis]

Released https://github.com/sabre-io/vobject/releases/tag/4.5.6 today.
Hoping to follow-up all the things in dav tomorrow and get that released.

[nickvergessen]

Anything we can assist with?

[phil-davis]

I finally got around to it!
https://github.com/sabre-io/dav/releases/tag/4.7.0

[phil-davis]

If there are any other PHP 8.4 issues found, then please reopen and we can sort them out.

[nickvergessen]

Will update our CI and check if there are any issues there and on the test servers that deploy master/main

[phil-davis]

CI passed for owncloud owncloud/core#41329