Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cargo: Ensure 'perf' doesn't enable 'std' implicitly #1150

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

cargo: Ensure 'perf' doesn't enable 'std' implicitly #1150

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion regex-automata/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ perf = ["perf-inline", "perf-literal"]
perf-inline = []
perf-literal = ["perf-literal-substring", "perf-literal-multisubstring"]
perf-literal-substring = ["aho-corasick?/perf-literal", "dep:memchr"]
perf-literal-multisubstring = ["std", "dep:aho-corasick"]
perf-literal-multisubstring = ["dep:aho-corasick"]

# Enables all Unicode features. This expands if new Unicode features are added.
unicode = [
Expand Down
4 changes: 4 additions & 0 deletions regex-automata/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -451,6 +451,10 @@ useful in trying to understand what the meta regex engine is doing.

### Performance features

**Note**:
To get performance benefits offered by the SIMD, `std` must be enabled.
None of the `perf-*` features will enable `std` implicitly.

* **perf** - Enables all of the below features.
* **perf-inline** - When enabled, `inline(always)` is used in (many) strategic
locations to help performance at the expense of longer compile times and
Expand Down
4 changes: 4 additions & 0 deletions src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1183,6 +1183,10 @@ default are noted.

### Performance features

**Note**:
To get performance benefits offered by the SIMD, `std` must be enabled.
None of the `perf-*` features will enable `std` implicitly.

* **perf** -
Enables all performance related features except for `perf-dfa-full`. This
feature is enabled by default is intended to cover all reasonable features
Expand Down