Adding network-wait-timeout support #1573
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RishabhSaini
force-pushed
the
pr/cos-1694
branch
from
84dc94f
to
ec3a78f
Compare
cgwalters
reviewed
Sep 9, 2022
RishabhSaini
force-pushed
the
pr/cos-1694
branch
from
ec3a78f
to
f5d11e3
Compare
implemented getters and setters for it dnf-repo: Call to librepo for network wait api call Add network-wait support by calling in API's from librepo
RishabhSaini
force-pushed
the
pr/cos-1694
branch
from
f5d11e3
to
27dcc91
Compare
|
The error message from CI isn't obvious to me. Maybe one of the maintainers here knows? That said @RishabhSaini if you want to debug this, there's a useful trick to debug Github actions specifically which is basically to force push your PR's code to your fork's
Then, you'll see the ctions run on your fork's Actions tab over here: https://github.com/RishabhSaini/libdnf/actions |
|
Ok thanks, will have a look at it |
|
Sorry for the inconvenience, the CI is currently broken, I am working on fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports to fix the issue: coreos/rpm-ostree#3096
dnf-context.cpp: Added network_wait seconds to struct DnfContext and implemented getters
and setters for it
dnf-repo.cpp: Call to librepo for network wait api call
Adding network wait support by callin in API's from librepo