Added network-wait support #3981
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgwalters
previously approved these changes
Sep 9, 2022
rpmostree-pkg-builtins.cxx: Adds a command line flag for --network-wait rpmostree-sysroot-upgrader.cxx: Adds network_wait to struct SysrootUpgrader and support for setting it rpmostree-transaction-types.cxx: Addresses a call to network wait by adding to struct sysroot_upgrader For each configured ostree remote and each enabled yum repository, wait until we can reach those over the network. This requires modifications in libdnf and librepo
RishabhSaini
force-pushed
the
pr/cos-1694
branch
from
460da67
to
1a01ee3
Compare
|
Updated. Resolved the changes |
|
@RishabhSaini: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@RishabhSaini: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3096
The changes required for this to work
libdnf: rpm-software-management/libdnf#1573
librepo: rpm-software-management/librepo#264
rpmostree-pkg-builtins.cxx: Adds a command line flag for --network-wait
rpmostree-sysroot-upgrader.cxx: Adds network_wait to struct SysrootUpgrader and support for setting it
rpmostree-transaction-types.cxx: Addresses a call to network wait by adding to struct sysroot_upgrader
For each configured ostree remote and each enabled yum repository, wait until we can reach those over the network.
This requires modifications in libdnf and librepo