Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[humble] rosbag2_storage linking to yaml-cpp::yaml-cpp #1831

Closed
PizzocaroSolomon opened this issue Oct 11, 2024 · 1 comment
Closed

[humble] rosbag2_storage linking to yaml-cpp::yaml-cpp #1831

PizzocaroSolomon opened this issue Oct 11, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@PizzocaroSolomon
Copy link

Hello everyone,

We have a project containing targets linking to rosbag2_storage and the standard yaml-cpp library.
During compilation, we get the following CMake warning:

image

We're certain that all our targets are linking to yaml-cpp using the target yaml-cpp::yaml-cpp.

Inside "/opt/ros/humble/share/rosbag2_storage/cmake/export_rosbag2_storageExport.cmake" we noticed the following lines:

set_target_properties(rosbag2_storage::rosbag2_storage PROPERTIES INTERFACE_INCLUDE_DIRECTORIES "${_IMPORT_PREFIX}/include/rosbag2_storage" INTERFACE_LINK_LIBRARIES "pluginlib::pluginlib;rcpputils::rcpputils;rcutils::rcutils;yaml-cpp" )

and substituting "yaml-cpp" with "yaml-cpp::yaml-cpp", the warning disappears.

We are convinced that this is a dirty solution to our problem.
Do you have any suggestions on what we can do to remove the warning cleanly?
Is it possible to add this "fix" to one of the next releases of ROS2 humble?

thank you very much!

@PizzocaroSolomon PizzocaroSolomon added the enhancement New feature or request label Oct 11, 2024
@clalancette
Copy link
Contributor

Closing as a duplicate of #1830.

@clalancette clalancette closed this as not planned Won't fix, can't repro, duplicate, stale Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants