Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture implicit message definitions for action feedback messages #1528

Open
taughz opened this issue Jan 5, 2024 · 1 comment
Open

Capture implicit message definitions for action feedback messages #1528

taughz opened this issue Jan 5, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@taughz
Copy link

taughz commented Jan 5, 2024

Description

I would like to be able to record a bag using --include-hidden-topics and have it capture implicit message definitions for action feedback messages, e.g., action_tutorials_interfaces/action/Fibonacci_FeedbackMessage. I know service introspection is on the way for Jazzy, but it's unclear to me if service introspection solves this problem. I'm currently on Humble and using -s mcap; I also tried Iron and Rolling, but got the same error message:

[ERROR] [1704486429.414617621] [rosbag2_cpp]: Message type name 'action_tutorials_interfaces/action/Fibonacci_FeedbackMessage' not understood by type definition search, definition will be left empty in bag.

It looks like work on this feature was started in #1341, but then that effort was stopped. (Was there another issue or PR that replaced that one?)

Related Issues

Completion Criteria

  • The implicit message definition is somehow captured and stored in the bag.
  • No longer see the not understood by type definition search error message.

Implementation Notes / Suggestions

  • None.

Testing Notes / Suggestions

  • None.
@taughz taughz added the enhancement New feature or request label Jan 5, 2024
@ryank-cobot
Copy link

I would also love this functionality!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants