Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get valid subscription handle even if cft failed #672

Open
wants to merge 1 commit into
base: rolling
Choose a base branch
from
Open

get valid subscription handle even if cft failed #672

wants to merge 1 commit into from

Conversation

iuhilnehc-ynos
Copy link
Contributor

@iuhilnehc-ynos iuhilnehc-ynos commented Feb 27, 2023 •
edited
Loading

rcl need to continue to try rcl cft fallback if rmw implementation failed to call rmw cft.

This was referenced Feb 27, 2023
Open
Open
MiguelCompany
MiguelCompany requested changes Feb 27, 2023
View reviewed changes
Copy link
Collaborator

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose this also needs to be changed on rmw_fastrtps_dynamic_cpp

@iuhilnehc-ynos
Copy link
Contributor Author

iuhilnehc-ynos commented Feb 27, 2023 •
edited
Loading

rmw_fastrtps_dynamic_cpp does not currently support CFT(see here), so there is no update for rmw_fastrtps_dynamic_cpp.

@fujitatomoya
Copy link
Collaborator

@iuhilnehc-ynos can you rebase just in case and start CI for this?

@iuhilnehc-ynos iuhilnehc-ynos force-pushed the topic-valid-handle-even-if-cft-failed branch from 7e6d2c3 to abfed56 Compare September 5, 2023 04:36
@iuhilnehc-ynos
Copy link
Contributor Author

@fujitatomoya Please see ros2/rmw_implementation#217 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiguelCompany MiguelCompany MiguelCompany requested changes

@fujitatomoya fujitatomoya fujitatomoya approved these changes

@gbiggs gbiggs Awaiting requested review from gbiggs gbiggs is a code owner

@sloretz sloretz Awaiting requested review from sloretz sloretz is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iuhilnehc-ynos @fujitatomoya @MiguelCompany