-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added remapping resolution for action names #1170
base: rolling
Are you sure you want to change the base?
Conversation
I wasn't able to reproduce the test error locally. I think this might be related to/the same as #1016. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test would be ideal, similar with https://github.com/ros2/rcl/blob/rolling/rcl/test/rcl/test_remap_integration.cpp.
most of the comments for the action client can be applied to server implementation as well.
I have added tests for action name remapping as requested. @fujitatomoya do you think it is necessary to add tests for local arguments passed to |
Hi, I was was busy for some time and forgot about this PR. As far as I understand the errors, they are not related to my changes. There seem to be a lot of unexpected 'test_broadcaster_xy' nodes in the test environment of the rcl and projectroot test suites. Sorry for leaving this pr stale for so long. |
@Mergifyio rebase |
❌ Base branch update has failedGit reported the following error:
|
@JustusBraun can you rebase this? i tried that via Mergifyio but failed. |
Signed-off-by: Justus Braun <[email protected]>
Signed-off-by: Justus Braun <[email protected]>
Signed-off-by: Justus Braun <[email protected]>
Signed-off-by: Justus Braun <[email protected]>
Signed-off-by: Justus Braun <[email protected]>
Signed-off-by: Justus Braun <[email protected]>
@fujitatomoya done! Locally all test passed with |
Currently remapping of action names is not possible see ros2/ros2#1312 .
I have now stumbled over this multiple times and I think it is a useful feature, so i took a shot at implementing the remapping of action names. Please let me know if you have any comments or if I overlooked something.
Fixes ros2/ros2#1312.