packaging fixes

[mikeferguson]

No description provided.

[mikeferguson]

We've still got issues -- this PR is a WIP. Supercedes #771

[mikeferguson]

Debians still not building:

• dwa_local_Planner (needs tf2_geometry_msgs, possibly others)
• rotate_recovery (same)
• move_base (blocked, might have dependency issues)

[mikeferguson]

The tf2_geometry_msgs thing is actually related to: ros/geometry2#275

[ 50%] Building CXX object CMakeFiles/rotate_recovery.dir/src/rotate_recovery.cpp.o
/usr/bin/c++  -DROSCONSOLE_BACKEND_LOG4CXX -DROS_PACKAGE_NAME=\"rotate_recovery\" -Drotate_recovery_EXPORTS -I/tmp/binarydeb/ros-melodic-rotate-recovery-1.16.1/include -I/opt/ros/melodic/include -I/opt/ros/melodic/share/xmlrpcpp/cmake/../../../include/xmlrpcpp -I/usr/include/eigen3  -g -O2 -fdebug-prefix-map=/tmp/binarydeb/ros-melodic-rotate-recovery-1.16.1=. -fstack-protector-strong -Wformat -Werror=format-security -DNDEBUG -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC   -o CMakeFiles/rotate_recovery.dir/src/rotate_recovery.cpp.o -c /tmp/binarydeb/ros-melodic-rotate-recovery-1.16.1/src/rotate_recovery.cpp
In file included from /opt/ros/melodic/include/tf2/utils.h:20:0,
                 from /tmp/binarydeb/ros-melodic-rotate-recovery-1.16.1/src/rotate_recovery.cpp:40:
/opt/ros/melodic/include/tf2/impl/utils.h:18:10: fatal error: tf2_geometry_msgs/tf2_geometry_msgs.h: No such file or directory
 #include <tf2_geometry_msgs/tf2_geometry_msgs.h>
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.

[mikeferguson]

Appears that move_base has all dependencies needed

[mikeferguson]

I think this is all the fixes that NEED to happen. Some other packages might benefit from a cleanup as well, but these are the ones that break builds.

For future reference, my approach was to grep for "include" in the package directory and make sure that every package providing headers was properly covered in the CMake. This is a bit of overkill, since some of these builds get away without everything being explicit, but it prevents the "hey we removed TF and nothing works anymore", or even worse "hey somebody else removed a depend, and now my build fails".