[ntuple] Binary format version 1.0.0.0 #16769
Conversation
jblomer
requested review from
hahnjo,
silverweed,
dpiparo,
vepadulano and
enirolf
jblomer
requested review from
bellenot,
linev,
martamaja10,
couet and
pcanal
as code owners
|
We should also adjust the tests that expect / allow "Pre-release format version" in the diagnostics |
| std::uint32_t fTypeVersionFrom = 0; | ||
| std::uint32_t fTypeVersionTo = 0; | ||
| /// Type version the extra type information is bound to | ||
| std::uint32_t fTypeVersion = 0; |
There was a problem hiding this comment.
Can we explicit in the commit log why the From/To is no longer needed?
gui/browsable/src/RFieldHolder.hxx
Outdated
| @@ -37,7 +37,7 @@ public: | |||
| { | |||
| } | |||
|
|
|||
| const TClass *GetClass() const override { return TClass::GetClass<ROOT::Experimental::RNTuple>(); } | |||
| const TClass *GetClass() const override { return TClass::GetClass<ROOT::RNTuple>(); } | |||
There was a problem hiding this comment.
Not strictly needed (and maybe annoying to do at this point) but I would recommend to have the commit that move all the classes out of the Experimental namespace to be the very last commit in the PR (so that technically there is no 'normal' way to get a RNTuple file with non-experiemental names and a not 'completely' 1.0 format.
Fair enough. However the comment #16769 (comment) is actually debating the split between this PR and #16645. |
Test Results 19 files 19 suites 4d 4h 15m 56s ⏱️ Results for commit 92e1aab. ♻️ This comment has been updated with latest results. |
I don't see enough reason to reshuffle the commits or PRs at this point. We can safely detect files from all PR states (RC2, RC3, version 1.0). |
jblomer
force-pushed
the
ntuple-v1
branch
5 times, most recently
from
cae1de5 to
ccf5aa5
Compare
|
As discussed, this should be merged only after a final round of tests with RC3 |
|
The tutorials also mention that the data format is still experimental and subject to change. This can be addressed in a separate PR, but it's something we shouldn't forget about. |
Reflect the fact that the on-disk format is stable. Only the API is still considered experimental.
Depends on #16645