Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't throw on ROOT::Experimental RNtuple warning #116

Closed
Tracked by #103
dan131riley opened this issue Apr 14, 2021 · 2 comments
Closed
Tracked by #103

Don't throw on ROOT::Experimental RNtuple warning #116

dan131riley opened this issue Apr 14, 2021 · 2 comments
Assignees

Comments

@dan131riley
Copy link
Collaborator

ROOT::Experimental::Detail::RPageSinkFile::RPageSinkFile(), in the RNtuple package

   R__WARNING_HERE("NTuple") << "The RNTuple file format will change. " <<
      "Do not store real data with this version of RNTuple!";

This should be added to the list of warnings that print instead of throwing.

Part of #103

@makortel
Copy link
Collaborator

With ROOT 6.34, I suppose we don't need to deal with this warning message anymore?

@dan131riley
Copy link
Collaborator Author

Since the storage format was frozen, this was removed in root-project/root#16769

@github-project-automation github-project-automation bot moved this from 🔖 Ready to ✅ Done in Framework tasks Dec 26, 2024
@makortel makortel reopened this Dec 26, 2024
@makortel makortel closed this as not planned Won't fix, can't repro, duplicate, stale Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

No branches or pull requests

2 participants