Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(iceberg): change http client max connection for iceberg compaction #20161

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −11
Open

feat(iceberg): change http client max connection for iceberg compaction #20161

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 5 additions & 11 deletions src/connector/src/sink/iceberg/compaction.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,17 +142,6 @@ async fn run_compact(

fn get_catalog_config(config: &IcebergConfig) -> anyhow::Result<HashMap<String, String>> {
match config.common.catalog_type.as_deref() {
Some("storage") | None => Ok(HashMap::from_iter([
("type".to_owned(), "hadoop".to_owned()),
(
"warehouse".to_owned(),
config
.common
.warehouse_path
.clone()
.ok_or_else(|| anyhow!("warehouse unspecified for jdbc catalog"))?,
),
])),
Some("jdbc") => Ok(HashMap::from_iter(
[
("type".to_owned(), "jdbc".to_owned()),
Expand All @@ -172,6 +161,10 @@ fn get_catalog_config(config: &IcebergConfig) -> anyhow::Result<HashMap<String,
.clone()
.ok_or_else(|| anyhow!("uri unspecified for jdbc catalog"))?,
),
(
"http-client.apache.max-connections".to_owned(),
"3000".to_owned(),
),
]
.into_iter()
.chain(
Expand All @@ -182,6 +175,7 @@ fn get_catalog_config(config: &IcebergConfig) -> anyhow::Result<HashMap<String,
.map(|(k, v)| (k.clone(), v.clone())),
),
)),
None => Err(anyhow!("catalog type unspecified")),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change removes the default storage catalog type behavior when catalog_type is None. This appears to be an unintentional breaking change that could impact existing configurations. Consider either:

  1. Restoring the previous default behavior for the None case:
None => Ok(HashMap::from_iter([
    ("type".to_owned(), "hadoop".to_owned()),
    ("warehouse".to_owned(), config.common.warehouse_path.clone()?),
])),
  1. Documenting this as an intentional breaking change and providing migration guidance for users

The choice depends on whether removing the default storage catalog type is intentional. If unintentional, option 1 is recommended to maintain backwards compatibility.

Spotted by Graphite Reviewer

Is this helpful? React 👍 or 👎 to let us know.

Some(other) => Err(anyhow!("unsupported catalog type {} in compaction", other)),
}
}
Expand Down
Loading