Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(iceberg): change http client max connection for iceberg compaction #20161

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

chenzl25
Copy link
Contributor

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

  • fine tune the iceberg spark compaction config to avoid HTTP connection error like software.amazon.awssdk.core.exception.SdkClientException: Unable to execute HTTP request: Timeout waiting for connection from pool.

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • My PR contains critical fixes that are necessary to be merged into the latest release.

Documentation

  • My PR needs documentation updates.
Release note

@@ -182,6 +175,7 @@ fn get_catalog_config(config: &IcebergConfig) -> anyhow::Result<HashMap<String,
.map(|(k, v)| (k.clone(), v.clone())),
),
)),
None => Err(anyhow!("catalog type unspecified")),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change removes the default storage catalog type behavior when catalog_type is None. This appears to be an unintentional breaking change that could impact existing configurations. Consider either:

  1. Restoring the previous default behavior for the None case:
None => Ok(HashMap::from_iter([
    ("type".to_owned(), "hadoop".to_owned()),
    ("warehouse".to_owned(), config.common.warehouse_path.clone()?),
])),
  1. Documenting this as an intentional breaking change and providing migration guidance for users

The choice depends on whether removing the default storage catalog type is intentional. If unintentional, option 1 is recommended to maintain backwards compatibility.

Spotted by Graphite Reviewer

Is this helpful? React 👍 or 👎 to let us know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant