Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup #464

Merged
merged 4 commits into from
May 20, 2024
Merged

Cleanup #464

merged 4 commits into from
May 20, 2024

Conversation

Abdulwadoodd
Copy link
Contributor

Description

  • fli.* tests got selected by the RISCOF even if zfa extension is not included in the ISA string in yaml configuration file. RVTEST_CASE macro is updated to check for zfa extension in the ISA string to select the test.
  • If DUT is configured for RV32, RISCOF tries to select and throws an error for most of rv64i_m/D_Zfa and rv64i_m/F_zfa tests that says tests selected without enabling the appropriate extensions. These tests are for RV64 - hence RVTEST_CASE macro is updated to check for RV64 in ISA string to select these tests.
  • Empty in one of the macros inside test_macros.h results in scary assembler warnings. so removed those spaces.

⚠️ It is important to note that the fixes in RVTEST_CASE macro for Zfa tests are not pulled in the corresponding cgf files. If the tests are generated from these GCF files again, they will have the same issues again. The best is to fix those cgf files or there should be an issue with open tracking (but I'm not sure where, either in riscv-arch-test or riscv-ctg?)

zfa instruction required for fli* instructions

Signed-off-by: Abdul Wadood <[email protected]>
Signed-off-by: Abdul Wadood <[email protected]>
Copy link
Collaborator

@allenjbaum allenjbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes an issue we discussed. Thanks for not regenerating all the tests! We can see exactly the exact same change in every test.

Copy link
Collaborator

@allenjbaum allenjbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I said earlier, this fixes an issue we discussed. We can see exactly the exact same change in every test, and a fix that removes a warning. Thanks for not regenerating all the tests!

@allenjbaum allenjbaum merged commit ed32d67 into riscv-non-isa:main May 20, 2024
2 checks passed
@Abdulwadoodd
Copy link
Contributor Author

Thanks Allen, for the review and merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants