Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ratified Zimop extension #387

Merged
merged 5 commits into from
May 7, 2024
Merged

Conversation

ved-rivos
Copy link
Contributor

@ved-rivos ved-rivos commented Sep 22, 2023

Description

Provide a detailed description of the changes performed by the PR.
Adds support for Zimop extension

Related Issues

Please list all the issues related to this PR. Use NA if no issues exist

Ratified/Unratified Extensions

  • Ratified
  • [] Unratified

List Extensions

List the extensions that your PR affects. In case of unratified extensions, please provide a link to the spec draft that was referred to make this PR.
https://github.com/riscv/riscv-isa-manual/blob/main/src/zimop.adoc

Reference Model Used

  • [X ] SAIL
  • Spike
  • Other - < SPECIFY HERE >

Mandatory Checklist:

  • [X ] All tests are compliant with the test-format spec present in this repo ?
  • [ X] Ran the new tests on RISCOF with SAIL/Spike as reference model successfully ?
  • Ran the new tests on RISCOF in coverage mode
  • Link to Google-Drive folder containing the new coverage reports (See this for more info): < SPECIFY HERE >
  • Link to PR in RISCV-ISAC from which the reports were generated : < SPECIFY HERE >
  • Changelog entry created with a minor patch

Optional Checklist:

  • [ X] RISCV-V CTG PR link if tests were generated using it : Add support for unratified Zimop extension riscv-software-src/riscv-ctg#80
  • Were the tests hand-written/modified ?
  • [ X] Have you run these on any hard DUT model ? Please specify name and provide link if possible in the description Spike
  • If you have modified arch_test.h Please provide a detailed description of the changes in the Description section above.

@allenjbaum
Copy link
Collaborator

allenjbaum commented Sep 29, 2023

We need to see the coverage report, from the checklist above, otherwise this looks good to go:

  • Ran the new tests on RISCOF in coverage mode
  • Link to Google-Drive folder containing the new coverage reports (See this for more info): < SPECIFY HERE >

@ved-rivos ved-rivos changed the title Add unratified Zimop extension Add ratified Zimop extension Apr 7, 2024
@UmerShahidengr
Copy link
Collaborator

As coverpoints and tests are complete, and all of its dependent PR have been merged, so I am merging it too.

Updated Changelog entry to resolve versioning issues and conflicts

Signed-off-by: Umer Shahid <[email protected]>
@UmerShahidengr UmerShahidengr merged commit 82a0981 into riscv-non-isa:main May 7, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants