Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding tests for covering registers as described in issue number 306 #385

Merged
merged 3 commits into from
Oct 1, 2023

Conversation

MuhammadHammad001
Copy link
Contributor

@MuhammadHammad001 MuhammadHammad001 commented Sep 18, 2023

Description

This PR contains the div-01.S files changed for the coverpoints mentioned in issue#306. I have generated the tests for the following coverpoints using the solution proposed in PR#79. The tests are generated the same way, the only changes were made in dataset.cgf for the addition of coverpoints and also in the generator.py of riscv-ctg. Please refer to the above mentioned PR#79 to see which changes were made in generator.py
Note: Please follow the following format for the hardcode value registers for proper generation of tests.

     'rs1 == rd != rs2; rd != "x0"': 0
     'rs1 == rd != rs2; rd == "x0"': 0
     'rs1 == "x0" != rd': 0
     'rd == "x0" != rs1': 0

Related Issues

issue#306

Ratified/Unratified Extensions

  • Ratified
  • Unratified

List Extensions

RV32IM
RV64IM

Reference Model Used

  • SAIL
  • Spike
  • Other - < SPECIFY HERE >

Mandatory Checklist:

  • All tests are compliant with the test-format spec present in this repo ?
  • Ran the new tests on RISCOF with SAIL/Spike as reference model successfully ?
  • Ran the new tests on RISCOF in coverage mode
  • Link to Google-Drive folder containing the new coverage reports (See this for more info): PR#385
  • Link to PR in RISCV-ISAC from which the reports were generated : < SPECIFY HERE >
  • Changelog entry created with a minor patch

Optional Checklist:

  • RISCV-V CTG PR link if tests were generated using it : PR#79.
  • Were the tests hand-written/modified ? -- div-01.S was modified.
  • Have you run these on any hard DUT model ? Please specify name and provide link if possible in the description
  • If you have modified arch_test.h Please provide a detailed description of the changes in the Description section above.

Copy link
Collaborator

@allenjbaum allenjbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We now see example of rs1, rs2, and rd all selecting X0

@allenjbaum
Copy link
Collaborator

This needs the changelog entry to be updated, and then it's good to go

@allenjbaum
Copy link
Collaborator

I should have asked you to pull form the latest changelog before pushing the change; there were several merges going on at the same time...

Copy link
Collaborator

@allenjbaum allenjbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, it looks likere are 2 v3.7.2, let's see what hap[ens

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants