Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typos in CONTRIBUTION.md #384

Merged
merged 2 commits into from
Oct 4, 2023
Merged

Fix typos in CONTRIBUTION.md #384

merged 2 commits into from
Oct 4, 2023

Conversation

visitorckw
Copy link
Contributor

  • the the RVI approved-> the RVI approved
  • you are be expected to -> you are expected to

allenjbaum
allenjbaum approved these changes Sep 18, 2023
View reviewed changes
Copy link
Collaborator

@allenjbaum allenjbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a correct fix

@allenjbaum
Copy link
Collaborator

All changes are expected to update the change log. Once that is done, it will be merged.

@visitorckw
Copy link
Contributor Author

Thank you for the reminder.
I've updated the change log with the required information.

@visitorckw visitorckw force-pushed the fix/typo branch 2 times, most recently from 7069811 to 37ce552 Compare September 29, 2023 16:03
@allenjbaum
Copy link
Collaborator

We have conflicts because there are multiple changes with the same version number. Could you update the changelog to the latest number+.1?

@visitorckw
Fix typos in CONTRIBUTION.md
12014fa 
- the the RVI approved-> the RVI approved
- you are be expected to -> you are expected to
@visitorckw
Update CHANGELOG.md
fb41944
@visitorckw
Copy link
Contributor Author

Thank you for your feedback. I have resolved the conflicts and updated the changelog to reflect the latest version number.

@allenjbaum allenjbaum merged commit 47cc654 into riscv-non-isa:main Oct 4, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allenjbaum allenjbaum allenjbaum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@visitorckw @allenjbaum