Fixed text wrap obtaining the incorrect glyph width #5620
+18
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Due to an implementation error, every glyph was considered of width 3.
Also, changed the widths of
CHAR_PROMPT_CLEARto 8 to account for the down arrow sprite and removed a DebugPrintf left in the code.Images
Before vs after
Differences in widths of glyphs
Issue(s) that this PR fixes
Fixes #5616
People who collaborated with me in this PR
@AlexOn1ine for their help verifying that the fix works with one of his custom strings.
Discord contact info
AsparagusEduardo