Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved mon pic tables to gSpeciesInfo + macro cleanup #5597

Open
wants to merge 4 commits into
base: upcoming
Choose a base branch
from

Conversation

AsparagusEduardo
Copy link
Collaborator

@AsparagusEduardo AsparagusEduardo commented Oct 27, 2024

Migrated overworld pic tables into compound structs in gSpeciesInfo.

Things to note in the release changelog:

  • OVERWORLD now has a required _anims argument, which replaces the need for OVERWORLD_SET_ANIM. For this, sAnimTable_Following was added on every previous use of OVERWORLD.
  • OVERWORLD and OVERWORLD_FEMALE now use a shared OVERWORLD_DATA macro. On top of making it cleaner, it allows female Pokémon to have their own custom animations, like OVERWORLD_SET_ANIM.

Discord contact info

AsparagusEduardo

@AsparagusEduardo AsparagusEduardo marked this pull request as draft October 27, 2024 00:54
@AsparagusEduardo AsparagusEduardo changed the title Renamed folders and symbols to match species defines Cleaned up Overworld mon macros Oct 27, 2024
@AsparagusEduardo AsparagusEduardo changed the title Cleaned up Overworld mon macros Moved mon pic tables to gSpeciesInfo + macro cleanup Oct 27, 2024
@AsparagusEduardo AsparagusEduardo added category: pokemon Pertains to Pokémon data and functionality type: cleanup labels Oct 27, 2024
@AsparagusEduardo AsparagusEduardo added this to the 1.10 milestone Oct 27, 2024
@AsparagusEduardo AsparagusEduardo force-pushed the _RHH/pr/upcoming/owPicTableInSpeciesInfo branch from 098c9ca to 3dc59b6 Compare October 29, 2024 15:00
@AsparagusEduardo AsparagusEduardo marked this pull request as ready for review October 29, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: pokemon Pertains to Pokémon data and functionality type: cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant