Remove cmd_recordability

[ghoulslash]

Removes cmd_recordability and calls directly in CreateAbilityPopup. This also catches abilityPopupOverwrite abilities

[PhallenTree]

All current uses of gBattleScripting.abilityPopupOverwrite don't require the overwriting ability to be recorded. abilityPopupOverwrite is used in the following cases:

1. Ability is changed (Doodle, Role Play, Wandering Spirit, Tera Shift).
   In this case gBattleScripting.abilityPopupOverwrite is the ability before it gets changed to the target's ability (the first two), the target's old ability and the attacker's old ability (Wandering Spirit) or the user's old ability before changing forms (Tera Shift -> Tera Shell).

2. Ability is changed to match the vanilla games' behavior of displaying each of the "As One" abilities (Unnerve and Chilling Neigh / Grim Neigh).

In this PR's current implementation, the ability recorded would either be the old ability (case 1) or part of the ability (case 2), which could cause AI issues (although in case 1 it's immediately overwritten to the correct ability again since it displays the user's new ability immediately after). *It doesn't currently cause AI issues because there isn't code checking for those abilities specifically from Recorded Abilities but it would still be ideal to record correct abilities.

[AlexOn1ine]

All current uses of gBattleScripting.abilityPopupOverwrite don't require the overwriting ability to be recorded.

Why is that?

[PhallenTree]

All current uses of gBattleScripting.abilityPopupOverwrite don't require the overwriting ability to be recorded.

Why is that?

Upon reviewing more AI code, I've changed my opinion, should be fine to do so to keep AI_PARTY's ability tracker updated.

[PhallenTree]

Suggested change:
In battle_ai_util.c, RecordAbilityBattle:
AI_PARTY->mons[side][partyIndex].ability should only be changed if AI_PARTY->mons[side][partyIndex].ability == ABILITY_NONE

Fixes the following scenario:
A mon has Protean, uses Skill Swap, and obtains Drought, AI_PARTY->mons[side][partyIndex]->ability for that mon becomes Drought instead of keeping it as Protean. Upon switching out and switching back in again, the AI thinks this mon has Drought instead of Protean.

Along with the changes made in this PR, most of these cases should be fixed.

[AlexOn1ine]

@ghoulslash could you address the comment from Phallen?