Add Chooseboxmon special #5428
Open
Add Chooseboxmon special #5428
+60
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bassoonian
reviewed
Sep 27, 2024
src/pokemon_storage_system.c
Outdated
| @@ -6197,7 +6221,7 @@ static void SaveCursorPos(void) | |||
| sSavedCursorPosition = sCursorPosition; | |||
| } | |||
|
|
|||
| static u8 GetSavedCursorPos(void) | |||
| u8 GetSavedCursorPos(void) | |||
There was a problem hiding this comment.
What's the point of this no longer being static if it isn't used outside of this file?
There was a problem hiding this comment.
Ah, this can be changed back to static. I was calling this in other files before I set the cursor position to gSpecialVar_0x8004
| @@ -10210,3 +10247,14 @@ void UpdateSpeciesSpritePSS(struct BoxPokemon *boxMon) | |||
| } | |||
| sJustOpenedBag = FALSE; | |||
| } | |||
|
|
|||
| u8 GetInPartyMenu(void) | |||
There was a problem hiding this comment.
This function is unused
There was a problem hiding this comment.
I made it for determining if the pokemon was in the party or not from other files after the pokemon had been selected. Not sure if there was another way to determine this
Co-authored-by: Bassoonian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a
ChooseBoxMonspecial that can be used instead ofChoosePartyMonto select a Pokemon. This only provides functionality forChooseBoxMonand does not modify any other functions to handle the results.ChooseBoxMonreturns the species selected inVAR_RESULT(for NPCs that ask to see specific Pokemon) and the Pc box cursor position/party slot id inVAR_0x8004(asChoosePartyMonuses that var for the party slot id).The
BoxMondata can be found by using these 3 functionsGetInPartyMenuwhich returns 1 if the Pokemon selected is in the party, 0 otherwiseGetSavedCursorPosreturns either the party slot id of the slot id in the boxStorageGetCurrentBoxreturns the box idYou can then use either
&gPlayerParty[slotId]or&gPokemonStoragePtr->boxes[boxId][slotId]to get the Pokemon's data.See this commit for an example of how to use this for the daycare.
Images
Discord contact info
paccy.