Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Battle Test Runner Failsafes/Improvements #5399

Closed
wants to merge 1 commit into from
Closed

Battle Test Runner Failsafes/Improvements #5399

wants to merge 1 commit into from

Conversation

ghoulslash
Copy link
Collaborator

@ghoulslash ghoulslash commented Sep 18, 2024 •
edited
Loading

  1. Failsafe check on assigned move PP. If a mon has a moveset with a single move, PP in move slot 2+ will be 0, so some tests will fail with a hard-to-track issue
  2. TryMessage has been improved to be more similar to a StringCopy function/simpler to read. It also will skip over ext ctrl codes for colors. The loop will now basically skip over any space, \p, \n etc code as well as colors and just compare relevant characters.

@AlexOn1ine AlexOn1ine added the category: battle-tests Related to the automated test environment label Sep 19, 2024
@AsparagusEduardo
Copy link
Collaborator

Can you please target this to master?

@ghoulslash
Copy link
Collaborator Author

superseded by #5525

@ghoulslash ghoulslash closed this Oct 15, 2024
@ghoulslash ghoulslash deleted the rhh/testrunner branch October 20, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AsparagusEduardo AsparagusEduardo AsparagusEduardo left review comments

@mrgriffin mrgriffin Awaiting requested review from mrgriffin

Assignees
No one assigned
Labels
category: battle-tests Related to the automated test environment
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ghoulslash @AsparagusEduardo @AlexOn1ine